Skip to content

Added fixity declaration to (..) (range operator) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2015
Merged

Added fixity declaration to (..) (range operator) #27

merged 1 commit into from
Feb 18, 2015

Conversation

pseudonom
Copy link
Contributor

I'm not certain exactly what the fixity declaration should be, but it seems that (..) should have one.

@paf31
Copy link
Contributor

paf31 commented Feb 18, 2015

How does this work with things like >>= and <$>? Those are my only real use cases where precedence seems important:

show <$> 1 .. 5
1 .. 5 >>= \n -> [n, n * 2]

should parse as

show <$> (1 .. 5)
(1 .. 5) >>= \n -> [n, n * 2]

I think it does, but could you please check

@pseudonom
Copy link
Contributor Author

Sure. I checked and adding the fixity declaration in the patch makes both of those work.

paf31 added a commit that referenced this pull request Feb 18, 2015
@paf31
Merge pull request #27 from pseudonom/patch-1
df6edb7 
Added fixity declaration to (..) (range operator)
@paf31 paf31 merged commit df6edb7 into purescript:master Feb 18, 2015
@paf31
Copy link
Contributor

paf31 commented Feb 18, 2015

I tested core-tests and test-everything too, everything looks good. Thanks!

@pseudonom pseudonom deleted the patch-1 branch February 18, 2015 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pseudonom @paf31